-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --without-components with subsetted components #119
Conversation
It's not entirely clear what changed in 1.66, but rust-lang/rust#105755 shows that we are failing to run the install script with --without if there are subsetted component names. This changes the behavior of the filtering to require an *exact* match rather than a partial match, which seems like the better way to go. It's not very clear to me that the previous behavior was actually a good idea.
Failed to set assignee to
|
I trust pietro's review, not sure when I'll get a chance to look at this, but I do want to mention that rust-lang/rust#102565 might have regressed something by accident. I glanced at the code and this seems a lot less fragile than before though, so changing rust-installer instead of reverting seems good to me. |
That PR landed in 1.67, so I think it can't be responsible for breakage in 1.66? |
I do wish this could take into account renames known to Rustup so that the components would better match what people are used to, but not broken is better than broken 😅 |
Definitely happy to take a PR! If this wasn't a shell script I might even do it myself, but parsing TOML (I think necessary?) would be... very painful in shell. |
* `--without=component-a,component-b` now requires full component names. This fixes rust-lang#105755 (rust-lang/rust-installer#119).
…n514 Bump rust-installer `--without=component-a,component-b` now requires full component names. This fixes rust-lang#105755 (rust-lang/rust-installer#119). dev-static build succeeded, and installer script seems to work (see comment in thread).
* `--without=component-a,component-b` now requires full component names. This fixes rust-lang#105755 (rust-lang/rust-installer#119).
It's not entirely clear what changed in 1.66, but rust-lang/rust#105755 shows that we are failing to run the install script with --without if there are subsetted component names.
This changes the behavior of the filtering to require an exact match rather than a partial match, which seems like the better way to go. It's not very clear to me that the previous behavior was actually a good idea.
r? @jyn514 or @pietroalbini
cc rust-lang/rust#105755
Will run a try build + dev-static nightly to check this actually works, but altering the 1.66 release with these changes did seem to do the right thing. (But I think the easiest thing is to merge this first and then do that later).