Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in echo #48

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Use built-in echo #48

merged 2 commits into from
Aug 23, 2016

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Aug 22, 2016

Fixes #47 by only using built-in echo. Also uses set -e so that bash will fail on the first error, rather than silently producing a corrupt manifest.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Aug 22, 2016

Sweet. I'll test on mingw and mac before morging.

@brson brson merged commit 755bc3d into rust-lang:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants