Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing lines from rla log #87

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix missing lines from rla log #87

wants to merge 5 commits into from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Oct 16, 2024 •
edited
Loading

This fixes weird behavior when rla parses log like:

##[group]Operating System
Ubuntu
20.04.6
LTS
##[endgroup]

and outputs it like:

##[group]Operating System
Ubuntu
LTS
LTS
##[endgroup]

I'm not completely sure that i understand all logic around, but this at least fixed that issue; more tests can be added any way.

This PR also updates few outdated crates and makes small refactor around parse logic, see individual commits.

Related: #66, #60, #59 but can't retest because logs removed long ago.

@klensy
Copy link
Contributor Author

klensy commented Nov 9, 2024

r? @Mark-Simulacrum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klensy