Skip to content

emacs23 support in travis is failing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikomatsakis opened this issue Feb 6, 2015 · 2 comments · Fixed by #30
Closed

emacs23 support in travis is failing #27

nikomatsakis opened this issue Feb 6, 2015 · 2 comments · Fixed by #30

Comments

@nikomatsakis
Copy link
Contributor

Currently emacs23 tests are broken. @pnkfelix and I were unable to reproduce the failures locally. For now we disabled emacs23 testing, but we'd like to re-enable it. We'll need some advice on what is wrong or how to reproduce the problems locally.

Example failures:

https://travis-ci.org/rust-lang/rust-mode/jobs/49740311

cc @MicahChalmer

@pnkfelix
Copy link
Member

pnkfelix commented Feb 6, 2015

(to be clear: we were unable to run the test suite on emacs23 locally. Its not as if we ran the test suite and the tests appeared to succeed.)

@MicahChalmer
Copy link
Contributor

Since #25 was closed and this is still open, I'll repeat myself here as to how to run ERT locally with emacs 23:

ERT was a standalone package through emacs 23, but was then made part of emacs for emacs 24. In the travis config, I have it download it from https://raw.githubusercontent.com/ohler/ert/c619b56c5bc6a866e33787489545b87d79973205/lisp/emacs-lisp/ert.el (that URL is still present in the .travis.yml here, but the use of it in the build has been disabled by #26. Grab it and put it in a place where emacs will know where to find it (the site-lisp directory where it's installed, for instance) and the tests will run.

I might submit a PR adding some info to the README on emacs version support, including instructions on how to run the tests locally. #21 helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants