Emacs 23 Fixups #30
Merged
Emacs 23 Fixups #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -289,7 +289,11 @@ very very very long string | |||
| (rust-test-manip-code | |||
| deindented | |||
| 1 | |||
| (lambda () (indent-region 1 (buffer-size))) | |||
| (lambda () | |||
| ;; The indentation will fial in some cases if the syntax properties are | |||
There was a problem hiding this comment.
typo here (but I'm not going to block merging the PR on this).
|
@MicahChalmer commit 6b57bbf from this PR broken indentation for me ( |
|
I found a case where the current code has non-deterministic behavior even in batch mode when running the tests! I'll open another issue with the details rather than posting it at the bottom of this one. But there is definitely a problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27 as follows:
Also fixes #28, which was present in all emacs versions (I happened on it while fixing doing the rest of this, then saw that it had been filed as #28 in the meantime.)