Fix quotes with syntax properties #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a8fad0f broke the ERT tests by removing trailing whitespace inside the test strings. Fix the tests, and replace some line endings inside strings with explicit "\n" to avoid having further significant trailing whitespace in the code.
This uses syntax properties to make it so that emacs recognizes the single quote, rather than the double quote, as the string delimiter within character literals, while leaving the syntax unchanged elsewhere.
|
Are there any tests of character literal parsing? I would in particular like to see tests of |
|
I added a test for |
|
@MicahChalmer hey thanks for following up; I took the liberty of cherry-picking the first commit in the series because that seemed important for overall workflow (at least for me). I'll be looking at the other commits shortly. |
pnkfelix
added a commit
that referenced
this pull request
Feb 6, 2015
…ties Fix quotes with syntax properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses syntax properties to make it so that emacs recognizes the single quote, rather than the double quote, as the string delimiter within character literals, while leaving the syntax unchanged elsewhere.
Also included is a commit that restores ERT tests that were inadvertently broken by an earlier commit (removing trailing whitespace broke the tests--I restored them and made it so they are no longer dependent on having trailing whitespace in the code.)
Fixes #1.
Fixes #6.