Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri is outdated #548

Closed
RalfJung opened this issue Nov 24, 2019 · 5 comments · Fixed by rust-lang/rust#66822
Closed

Miri is outdated #548

RalfJung opened this issue Nov 24, 2019 · 5 comments · Fixed by rust-lang/rust#66822

Comments

@RalfJung
Copy link
Member

The Miri on playground is from 2019-11-08, there have been quite a few updates since then.
@RalfJung
Copy link
Member Author

@Aaron1011 see the build log at https://travis-ci.com/integer32llc/rust-playground/jobs/259856086:

error: failed to run custom build command for `html5ever v0.23.0`

Caused by:

  process didn't exit successfully: `/playground/target/debug/build/html5ever-e09cbe0abacfb0e8/build-script-build` (signal: 4, SIGILL: illegal instruction)

This might have to do with the cfg(miri) in libunwind?

@RalfJung RalfJung mentioned this issue Nov 27, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Dec 1, 2019
@Centril
Rollup merge of rust-lang#66822 - RalfJung:miri-panic, r=oli-obk
b215445 
libunwind_panic: adjust miri panic hack

We adjust the Miri hack in libpanic_unwind such that even with `cfg(miri)`, we build a version of libpanic_unwind that actually works.

This is needed to resolve rust-lang/rust-playground#548.

r? @oli-obk @alexcrichton
RalfJung added a commit to RalfJung/rust that referenced this issue Dec 2, 2019
@RalfJung
Rollup merge of rust-lang#66822 - RalfJung:miri-panic, r=oli-obk
b7f8b77 
libunwind_panic: adjust miri panic hack

We adjust the Miri hack in libpanic_unwind such that even with `cfg(miri)`, we build a version of libpanic_unwind that actually works.

This is needed to resolve rust-lang/rust-playground#548.

r? @oli-obk @alexcrichton
@RalfJung
Copy link
Member Author

RalfJung commented Dec 2, 2019

This should be fixed by rust-lang/rust#66822

@RalfJung RalfJung closed this as completed Dec 2, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Dec 6, 2019

@shepmaster This time the Miri job ran successfully, but on playground it still says "2019-11-08". Any idea why?

@RalfJung RalfJung reopened this Dec 6, 2019
@shepmaster
Copy link
Member

Looking now, it says 12-04; perhaps just the timing between when it’s built and when the playground downloaded it?

@RalfJung
Copy link
Member Author

RalfJung commented Dec 8, 2019

Yeah must have been something like that.

@RalfJung RalfJung closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libunwind_panic: adjust miri panic hack RalfJung/rust
2 participants
@shepmaster @RalfJung