Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Rendered link" to PR to quick see the rendered changes #213

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jan 7, 2025

This PR adds "Rendered link" to PR to quick see the rendered changes.

I have configured it to only trigger on files under the src/ directory.

Example

image

Note, despite the triagebot.toml being new, triagebot/rustbot is already activated for this repo.

@lqd
Copy link
Member

lqd commented Jan 7, 2025

We can only test this after merging, right?

@Urgau
Copy link
Member Author

Urgau commented Jan 7, 2025

Test the effect yes, only after merging and having a new (or updated) PR.
The config is already validated, as triagebot hasn't complained.

You can however look at PRs in rust-lang/rfcs and blog.rust-lang.org which have the rendered links.

@lqd
Copy link
Member

lqd commented Jan 7, 2025

Let’s see then. Thanks!

@lqd lqd merged commit c9da2db into rust-lang:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants