Rework #123
Open
Rework #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULLx76
force-pushed
the
refactor
branch
3 times, most recently
from
4265e85
to
dd071a8
Compare
still need to fix: - timeout - csv file header
NULLx76
commented
Oct 21, 2024
NULLx76
commented
Oct 21, 2024
| @@ -1,27 +1,8 @@ | |||
| // Copyright (c) 2018 Pietro Albini <pietro@pietroalbini.org> | |||
There was a problem hiding this comment.
These copyright notices seemed redundant as there is also a LICENSE file, if we do really want them I can add them back
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #121, #122
Mostly done, still expect to make some changes.
state.jsonhas a different file format, can easily be changed../data_newfor testing?everywhere