Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

cargo semver does not pass extra options to cargo #97

Open
whentze opened this issue Mar 24, 2019 · 2 comments
Open

cargo semver does not pass extra options to cargo #97

whentze opened this issue Mar 24, 2019 · 2 comments

Comments

@whentze
Copy link
Contributor

whentze commented Mar 24, 2019

The usage message for cargo semver states:

usage: cargo semver [options] [-- cargo options]

However, additional options after -- are not passed on to cargo.
We should either make that work again or fix the usage message.

@ibabushkin
Copy link
Contributor

Alright, so juding by the state of things in cargo, we cannot pass the free strings left over from command line parsing to cargo since we are not shelling out. So for now I'll just add a disclaimer that this feature does not work and see if we can get it in a different way.

@ibabushkin
Copy link
Contributor

ibabushkin commented Jun 15, 2019

To unroll this further: What kind of flags do we actually need to support currently?

Most of these already have an issue and have clear-cut, relatively stable requirements. I currently cannot think of other flags we might want to support, but so far, I'd be in favor of implementing these features locally (including command line parsing) and then to reevaluate whether we want to refactor those bits to push that into cargo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants