Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .await syntax highlighting #327

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

seanmonstar
Copy link
Contributor

Also puts async into its own group in case one wants to highlight it differently.

@rust-highfive
Copy link

r? @chris-morgan

(rust_highfive has picked a reviewer for you, use r? to override)

@seanmonstar
Copy link
Contributor Author

@chris-morgan ping :)

@chris-morgan
Copy link
Member

I’m not convinced about requiring (tho not highlighting) the dot, rather than just highlighting await as a keyword. Convoluted code written by madmen that like breaking syntax highlighters:

a .
await
./**/await

Do you have a definite opinion on the presence of the dot in the highlighting, or did that just seem like the thing to do?

@seanmonstar
Copy link
Contributor Author

I had a small test file when I was writing this, and now I cannot remember why I thought it should start with a .. I'll remove that, for the sake of the madmen.

@seanmonstar
Copy link
Contributor Author

All set :D

@seanmonstar
Copy link
Contributor Author

@chris-morgan any other thoughts?

@chris-morgan chris-morgan merged commit 4c27b51 into rust-lang:master Jul 22, 2019
@chris-morgan
Copy link
Member

Thanks for the reminder!

@seanmonstar seanmonstar deleted the syntax-await branch September 27, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants