:setfiletype FALLBACK is not available in older versions
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
chris-morgan
requested changes
Aug 29, 2019
There is no workaround for this. If we would set the filetype first via `:set filetype=cfg` or `:setfiletype cfg`, more specialized plugins like vim-toml, wouldn't be able to overwrite the filetype with `:setfiletype toml` anymore. Now, we simply don't set a filetype at all for older Vim versions. Not great, but better than an error that keeps rust.vim from getting sourced properly. Fixes #345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no workaround for this. If we would set the filetype first via
:set filetype=cfgor:setfiletype cfg, more specialized plugins like vim-toml, wouldn't be able to overwrite the filetype with:setfiletype tomlanymore.Now, we simply don't set a filetype at all for older Vim versions. Not great, but better than an error that keeps rust.vim from getting sourced properly.
Fixes #345
Alternative: We remove the entire line. If someone wants syntax highlighting for toml, vim-toml should be used.
p.s. Works with Vim and Nvim.
p.p.s This is the recommended approach for checking versions (in older Vim verions):
:h has-patch.