Improve dummy bindings for unresolved imports

rust-lang · Feb 19, 2016 · 08b9097 · 08b9097
1 parent 1b5d2f2
commit 08b9097
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/librustc_resolve/resolve_imports.rs b/src/librustc_resolve/resolve_imports.rs
@@ -218,6 +218,8 @@ impl<'a, 'b:'a, 'tcx:'b> ImportResolver<'a, 'b, 'tcx> {
                 kind: NameBindingKind::Def(Def::Err),
                 span: None,
             });
+            let dummy_binding =
+                self.resolver.new_name_binding(e.import_directive.import(dummy_binding));
 
             let _ = e.source_module.try_define_child(target, ValueNS, dummy_binding);
             let _ = e.source_module.try_define_child(target, TypeNS, dummy_binding);

diff --git a/src/test/compile-fail/import.rs b/src/test/compile-fail/import.rs
@@ -19,6 +19,6 @@ mod zed {
 }
 
 fn main() {
-    zed::foo(); // Check that this does not panic. Ideally, it would be a privacy error.
+    zed::foo(); //~ ERROR unresolved name
     bar();
 }