Skip to content

Commit

Permalink
Reword tracking issue note
Browse files Browse the repository at this point in the history
  • Loading branch information
estebank committed Apr 11, 2019
1 parent 3ab9706 commit 146d040
Show file tree
Hide file tree
Showing 155 changed files with 375 additions and 372 deletions.
7 changes: 5 additions & 2 deletions src/libsyntax/feature_gate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1481,9 +1481,12 @@ fn leveled_feature_err<'a>(
};

match issue {
None | Some(0) => {}
None | Some(0) => {} // We still accept `0` as a stand-in for backwards compatibility
Some(n) => {
err.note(&format!("for more information, see tracking issue #{}", n));
err.note(&format!(
"for more information, see https://github.com/rust-lang/rust/issues/{}",
n,
));
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/ui/cast/cast-ptr-to-int-const.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: casting pointers to integers in constants is unstable
LL | main as u32
| ^^^^^^^^^^^
|
= note: for more information, see tracking issue #51910
= note: for more information, see https://github.com/rust-lang/rust/issues/51910
= help: add #![feature(const_raw_ptr_to_usize_cast)] to the crate attributes to enable

error[E0658]: casting pointers to integers in constants is unstable
Expand All @@ -13,7 +13,7 @@ error[E0658]: casting pointers to integers in constants is unstable
LL | &Y as *const u32 as u32
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51910
= note: for more information, see https://github.com/rust-lang/rust/issues/51910
= help: add #![feature(const_raw_ptr_to_usize_cast)] to the crate attributes to enable

error: aborting due to 2 previous errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: no_core is experimental
LL | #![cfg_attr(broken, no_core)]
| ^^^^^^^
|
= note: for more information, see tracking issue #29639
= note: for more information, see https://github.com/rust-lang/rust/issues/29639
= help: add #![feature(no_core)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: no_core is experimental
LL | #![cfg_attr(broken, no_core, no_std)]
| ^^^^^^^
|
= note: for more information, see tracking issue #29639
= note: for more information, see https://github.com/rust-lang/rust/issues/29639
= help: add #![feature(no_core)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: no_core is experimental
LL | #![cfg_attr(broken, no_std, no_core)]
| ^^^^^^^
|
= note: for more information, see tracking issue #29639
= note: for more information, see https://github.com/rust-lang/rust/issues/29639
= help: add #![feature(no_core)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ LL | #[cfg_attr(all(), unknown)]
LL | foo!();
| ------- in this macro invocation
|
= note: for more information, see tracking issue #29642
= note: for more information, see https://github.com/rust-lang/rust/issues/29642
= help: add #![feature(custom_attribute)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/consts/const-deref-ptr.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: dereferencing raw pointers in statics is unstable
LL | static C: u64 = unsafe {*(0xdeadbeef as *const u64)};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: unions in const fn are unstable
LL | Foo { u }.i
| ^^^^^^^^^^^
|
= note: for more information, see tracking issue #51909
= note: for more information, see https://github.com/rust-lang/rust/issues/51909
= help: add #![feature(const_fn_union)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
6 changes: 3 additions & 3 deletions src/test/ui/consts/const-eval/feature-gate-const_panic.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: panicking in constants is unstable
LL | const Z: () = panic!("cheese");
| ^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51999
= note: for more information, see https://github.com/rust-lang/rust/issues/51999
= help: add #![feature(const_panic)] to the crate attributes to enable
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Expand All @@ -14,7 +14,7 @@ error[E0658]: panicking in constants is unstable
LL | const X: () = unimplemented!();
| ^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51999
= note: for more information, see https://github.com/rust-lang/rust/issues/51999
= help: add #![feature(const_panic)] to the crate attributes to enable
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Expand All @@ -24,7 +24,7 @@ error[E0658]: panicking in constants is unstable
LL | const Y: () = unreachable!();
| ^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51999
= note: for more information, see https://github.com/rust-lang/rust/issues/51999
= help: add #![feature(const_panic)] to the crate attributes to enable
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/consts/const-eval/match-test-ptr-null.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ fn main() {
let _: [u8; 0] = [4; {
match &1 as *const i32 as usize {
//~^ ERROR casting pointers to integers in constants
//~| NOTE for more information, see tracking issue #51910
//~| NOTE for more information, see
0 => 42, //~ ERROR constant contains unimplemented expression type
//~^ NOTE "pointer arithmetic or comparison" needs an rfc before being allowed
//~| ERROR evaluation of constant value failed
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/consts/const-eval/match-test-ptr-null.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: casting pointers to integers in constants is unstable
LL | match &1 as *const i32 as usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51910
= note: for more information, see https://github.com/rust-lang/rust/issues/51910
= help: add #![feature(const_raw_ptr_to_usize_cast)] to the crate attributes to enable

error[E0019]: constant contains unimplemented expression type
Expand Down
8 changes: 4 additions & 4 deletions src/test/ui/consts/min_const_fn/min_const_fn_unsafe.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: dereferencing raw pointers in constant functions is unstable
LL | const fn bad_const_fn_deref_raw(x: *mut usize) -> &'static usize { unsafe { &*x } }
| ^^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error[E0658]: dereferencing raw pointers in constant functions is unstable
Expand All @@ -13,7 +13,7 @@ error[E0658]: dereferencing raw pointers in constant functions is unstable
LL | const unsafe fn bad_const_unsafe_deref_raw(x: *mut usize) -> usize { *x }
| ^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error[E0658]: dereferencing raw pointers in constant functions is unstable
Expand All @@ -22,7 +22,7 @@ error[E0658]: dereferencing raw pointers in constant functions is unstable
LL | const unsafe fn bad_const_unsafe_deref_raw_ref(x: *mut usize) -> &'static usize { &*x }
| ^^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error[E0658]: unions in const fn are unstable
Expand All @@ -31,7 +31,7 @@ error[E0658]: unions in const fn are unstable
LL | Foo { x: () }.y
| ^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #51909
= note: for more information, see https://github.com/rust-lang/rust/issues/51909
= help: add #![feature(const_fn_union)] to the crate attributes to enable

error[E0133]: dereference of raw pointer is unsafe and requires unsafe function or block
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/consts/projection_qualif.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ error[E0658]: dereferencing raw pointers in constants is unstable
LL | unsafe { *b = 5; }
| ^^^^^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error: aborting due to 3 previous errors
Expand Down
6 changes: 3 additions & 3 deletions src/test/ui/custom_attribute.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: The attribute `foo` is currently unknown to the compiler and may h
LL | #[foo]
| ^^^
|
= note: for more information, see tracking issue #29642
= note: for more information, see https://github.com/rust-lang/rust/issues/29642
= help: add #![feature(custom_attribute)] to the crate attributes to enable

error[E0658]: The attribute `foo` is currently unknown to the compiler and may have meaning added to it in the future
Expand All @@ -13,7 +13,7 @@ error[E0658]: The attribute `foo` is currently unknown to the compiler and may h
LL | #[foo]
| ^^^
|
= note: for more information, see tracking issue #29642
= note: for more information, see https://github.com/rust-lang/rust/issues/29642
= help: add #![feature(custom_attribute)] to the crate attributes to enable

error[E0658]: The attribute `foo` is currently unknown to the compiler and may have meaning added to it in the future
Expand All @@ -22,7 +22,7 @@ error[E0658]: The attribute `foo` is currently unknown to the compiler and may h
LL | #[foo]
| ^^^
|
= note: for more information, see tracking issue #29642
= note: for more information, see https://github.com/rust-lang/rust/issues/29642
= help: add #![feature(custom_attribute)] to the crate attributes to enable

error: aborting due to 3 previous errors
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/error-codes/E0395.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: comparing raw pointers inside static
LL | static BAZ: bool = unsafe { (&FOO as *const i32) == (&BAR as *const i32) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #53020
= note: for more information, see https://github.com/rust-lang/rust/issues/53020
= help: add #![feature(const_compare_raw_pointers)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/error-codes/E0396.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: dereferencing raw pointers in constants is unstable
LL | const VALUE: u8 = unsafe { *REG_ADDR };
| ^^^^^^^^^
|
= note: for more information, see tracking issue #51911
= note: for more information, see https://github.com/rust-lang/rust/issues/51911
= help: add #![feature(const_raw_ptr_deref)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/error-codes/E0658.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ LL | | Bar(u64),
LL | | }
| |_^
|
= note: for more information, see tracking issue #35118
= note: for more information, see https://github.com/rust-lang/rust/issues/35118
= help: add #![feature(repr128)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
14 changes: 7 additions & 7 deletions src/test/ui/explore-issue-38412.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | let Record { a_stable_pub: _, a_unstable_declared_pub: _, a_unstable_undeclared_pub: _, .. } =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'unstable_undeclared'
Expand All @@ -13,7 +13,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | r.a_unstable_undeclared_pub;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0616]: field `b_crate` of struct `pub_and_stability::Record` is private
Expand All @@ -40,7 +40,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | t.2;
| ^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0616]: field `3` of struct `pub_and_stability::Tuple` is private
Expand All @@ -67,7 +67,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | r.unstable_undeclared_trait_method();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'unstable_undeclared'
Expand All @@ -76,7 +76,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | r.unstable_undeclared();
| ^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0624]: method `pub_crate` is private
Expand All @@ -103,7 +103,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | t.unstable_undeclared_trait_method();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0658]: use of unstable library feature 'unstable_undeclared'
Expand All @@ -112,7 +112,7 @@ error[E0658]: use of unstable library feature 'unstable_undeclared'
LL | t.unstable_undeclared();
| ^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38412
= note: for more information, see https://github.com/rust-lang/rust/issues/38412
= help: add #![feature(unstable_undeclared)] to the crate attributes to enable

error[E0624]: method `pub_crate` is private
Expand Down
10 changes: 5 additions & 5 deletions src/test/ui/feature-gate-optimize_attribute.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: #[optimize] attribute is an unstable feature
LL | #[optimize(size)]
| ^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #54882
= note: for more information, see https://github.com/rust-lang/rust/issues/54882
= help: add #![feature(optimize_attribute)] to the crate attributes to enable

error[E0658]: #[optimize] attribute is an unstable feature
Expand All @@ -13,7 +13,7 @@ error[E0658]: #[optimize] attribute is an unstable feature
LL | #[optimize(speed)]
| ^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #54882
= note: for more information, see https://github.com/rust-lang/rust/issues/54882
= help: add #![feature(optimize_attribute)] to the crate attributes to enable

error[E0658]: #[optimize] attribute is an unstable feature
Expand All @@ -22,7 +22,7 @@ error[E0658]: #[optimize] attribute is an unstable feature
LL | #[optimize(banana)]
| ^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #54882
= note: for more information, see https://github.com/rust-lang/rust/issues/54882
= help: add #![feature(optimize_attribute)] to the crate attributes to enable

error[E0658]: #[optimize] attribute is an unstable feature
Expand All @@ -31,7 +31,7 @@ error[E0658]: #[optimize] attribute is an unstable feature
LL | #[optimize(size)]
| ^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #54882
= note: for more information, see https://github.com/rust-lang/rust/issues/54882
= help: add #![feature(optimize_attribute)] to the crate attributes to enable

error[E0658]: #[optimize] attribute is an unstable feature
Expand All @@ -40,7 +40,7 @@ error[E0658]: #[optimize] attribute is an unstable feature
LL | #![optimize(speed)]
| ^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #54882
= note: for more information, see https://github.com/rust-lang/rust/issues/54882
= help: add #![feature(optimize_attribute)] to the crate attributes to enable

error[E0722]: invalid argument
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/feature-gate/feature-gate-c_variadic.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: C-varaidic functions are unstable
LL | pub unsafe extern "C" fn test(_: i32, ap: ...) { }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #44930
= note: for more information, see https://github.com/rust-lang/rust/issues/44930
= help: add #![feature(c_variadic)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
error[E0658]: kind="static-nobundle" is feature gated
|
= note: for more information, see tracking issue #37403
= note: for more information, see https://github.com/rust-lang/rust/issues/37403
= help: add #![feature(static_nobundle)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: msp430-interrupt ABI is experimental and subject to change
LL | extern "msp430-interrupt" fn foo() {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: for more information, see tracking issue #38487
= note: for more information, see https://github.com/rust-lang/rust/issues/38487
= help: add #![feature(abi_msp430_interrupt)] to the crate attributes to enable

error: aborting due to previous error
Expand Down
Loading

0 comments on commit 146d040

Please sign in to comment.