-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename Integer trait
divides
to is_multiple_of
.
It is being changed because the previous wording was ambiguous. `a.divides(b)` implied `a % b == 0` but it sounds like the other way around. `9.divides(&3) == true` but we might read that as "does 9 divide 3?". It has been renamed to sidestep the ambiguity. Work around the change by using `is_multiple_of` instead. [breaking-change]
- Loading branch information
Showing
2 changed files
with
43 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at https://github.com/treeman/rust/commit/2a96e2aa15e14e16c9b10f5c5bb513ad6dc8a997
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging treeman/rust/issue-15710 = 2a96e2a into auto
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
treeman/rust/issue-15710 = 2a96e2a merged ok, testing candidate = 4084ec0d
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/557
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/557
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/556
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/556
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/556
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/557
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/556
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/562
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/556
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/559
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/557
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/558
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at https://github.com/treeman/rust/commit/2a96e2aa15e14e16c9b10f5c5bb513ad6dc8a997
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging treeman/rust/issue-15710 = 2a96e2a into auto
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
treeman/rust/issue-15710 = 2a96e2a merged ok, testing candidate = b8e46e66
2a96e2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/588
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/588
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/587
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/586
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/587
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/587
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/588
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/587
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/593
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/588
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/587
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/590
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/588
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/589