Skip to content

Commit

Permalink
auto merge of #6648 : alexcrichton/rust/issue-6633, r=graydon
Browse files Browse the repository at this point in the history
Resolves #6633 and removes an unnecessary import in libcore
  • Loading branch information
bors committed May 21, 2013
2 parents 5a3e320 + 15f97ac commit 329d8e2
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/libcore/vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use old_iter;
use iterator::Iterator;
use kinds::Copy;
use libc;
use old_iter::{BaseIter, CopyableIter};
use old_iter::CopyableIter;
use option::{None, Option, Some};
use ptr::to_unsafe_ptr;
use ptr;
Expand Down
4 changes: 4 additions & 0 deletions src/librustc/middle/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1834,6 +1834,10 @@ pub impl Resolver {
debug!("(building import directive) bumping \
reference");
resolution.outstanding_references += 1;

// the source of this name is different now
resolution.privacy = privacy;
resolution.id = id;
}
None => {
debug!("(building import directive) creating new");
Expand Down
29 changes: 29 additions & 0 deletions src/test/compile-fail/lint-unused-import-tricky-names.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[deny(unused_imports)];

// Regression test for issue #6633

use foo::name::name; //~ ERROR: unused import
use foo::name;

pub mod foo {
pub mod name {
pub type a = int;
pub mod name {
pub type a = float;
}
}
}

fn bar() -> name::a { 1 }

fn main(){}

0 comments on commit 329d8e2

Please sign in to comment.