Skip to content

Commit

Permalink
Convert NOTEs to FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
brson committed Feb 28, 2013
1 parent 269409f commit 4a04a18
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/libcore/comm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ use vec;

use pipes::{recv, try_recv, wait_many, peek, PacketHeader};

// NOTE Making this public exposes some plumbing from pipes. Needs
// some refactoring
// FIXME #5160: Making this public exposes some plumbing from
// pipes. Needs some refactoring
pub use pipes::Selectable;

/// A trait for things that can send multiple messages.
Expand Down
2 changes: 1 addition & 1 deletion src/rt/rust_upcall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ upcall_fail(char const *expr,
size_t line) {
rust_task *task = rust_try_get_current_task();
if (task == NULL) {
// NOTE: Need to think about what to do here
// FIXME #5161: Need to think about what to do here
printf("failure outside of a task");
abort();
}
Expand Down

11 comments on commit 4a04a18

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at brson@4a04a18

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging brson/rust/fixmes = 4a04a18 into auto

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brson/rust/fixmes = 4a04a18 merged ok, testing candidate = ae593623

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at brson@4a04a18

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging brson/rust/fixmes = 4a04a18 into auto

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brson/rust/fixmes = 4a04a18 merged ok, testing candidate = f3b99aa3

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Mar 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at brson@4a04a18

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Mar 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging brson/rust/fixmes = 4a04a18 into auto

@bors
Copy link
Contributor

@bors bors commented on 4a04a18 Mar 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brson/rust/fixmes = 4a04a18 merged ok, testing candidate = 1d34a55

Please sign in to comment.