Skip to content

Commit 4af29d1

Browse files
fmeaseNoratrieb
authored andcommitted
Add guidelines for backport-accepted PRs
1 parent fc36182 commit 4af29d1

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

src/contributing.md

+13
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,19 @@ to put the "closes #123" text in the PR description rather than the issue commit
263263
particularly during rebasing, citing the issue number in the commit can "spam"
264264
the issue in question.
265265

266+
However, if your PR fixes a stable-to-beta or stable-to-stable regression and has
267+
been accepted for a beta and/or stable backport (i.e., it is marked `beta-accepted`
268+
and/or `stable-accepted`), please do *not* use any such keywords since we don't
269+
want the corresponding issue to get auto-closed once the fix lands on master.
270+
Please update the PR description while still mentioning the issue somewhere.
271+
For example, you could write `Fixes (after beta backport) #NNN.`.
272+
273+
As for further actions, please keep a sharp look-out for a PR whose title begins with
274+
`[beta]` or `[stable]` and which backports the PR in question. When that one gets
275+
merged, the relevant issue can be closed. The closing comment should mention all
276+
PRs that were involved. If you don't have the permissions to close the issue, please
277+
leave a comment on the original PR asking the reviewer to close it for you.
278+
266279
[labeling]: ./rustbot.md#issue-relabeling
267280
[closing-keywords]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
268281

0 commit comments

Comments
 (0)