-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Some unix platforms will send a SIGPIPE signal instead of returning EPIPE from a syscall by default. The native runtime doesn't install a SIGPIPE handler, causing the program to die immediately in this case. This brings the behavior in line with libgreen by ignoring SIGPIPE and propagating EPIPE upwards to the application in the form of an IoError. Closes #13123
- Loading branch information
1 parent
b8601a3
commit 68c2706
Showing
3 changed files
with
84 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// ignore-fast | ||
|
||
// Be sure that when a SIGPIPE would have been received that the entire process | ||
// doesn't die in a ball of fire, but rather it's gracefully handled. | ||
|
||
use std::os; | ||
use std::io::{PipeStream, Process}; | ||
|
||
fn test() { | ||
let os::Pipe { input, out } = os::pipe(); | ||
let input = PipeStream::open(input); | ||
let mut out = PipeStream::open(out); | ||
drop(input); | ||
|
||
let _ = out.write([1]); | ||
} | ||
|
||
fn main() { | ||
let args = os::args(); | ||
if args.len() > 1 && args[1].as_slice() == "test" { | ||
return test(); | ||
} | ||
|
||
let mut p = Process::new(args[0], [~"test"]).unwrap(); | ||
assert!(p.wait().success()); | ||
} |
68c2706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@68c2706
68c2706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-13123 = 68c2706 into auto
68c2706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-13123 = 68c2706 merged ok, testing candidate = 42e1003
68c2706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4940
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4943
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4034
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4046
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5042
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4127
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4135
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5042
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4127
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4132
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4198
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1930
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5039
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4137
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4147
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4804
68c2706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 42e1003