Remove unnecessary CVarArgs name skipping logic

rust-lang · Oct 25, 2023 · 6aead74 · 6aead74
1 parent 2c1dbed
commit 6aead74
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/compiler/rustc_ast_lowering/src/lib.rs b/compiler/rustc_ast_lowering/src/lib.rs
@@ -1737,14 +1737,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
  }
 
  fn lower_fn_params_to_names(&mut self, decl: &FnDecl) -> &'hir [Ident] {
- // Skip the `...` (`CVarArgs`) trailing arguments from the AST,
- // as they are not explicit in HIR/Ty function signatures.
- // (instead, the `c_variadic` flag is set to `true`)
- let mut inputs = &decl.inputs[..];
- if decl.c_variadic() {
- inputs = &inputs[..inputs.len() - 1];
- }
- self.arena.alloc_from_iter(inputs.iter().map(|param| match param.pat.kind {
+ self.arena.alloc_from_iter(decl.inputs.iter().map(|param| match param.pat.kind {
  PatKind::Ident(_, ident, _) => self.lower_ident(ident),
  _ => Ident::new(kw::Empty, self.lower_span(param.pat.span)),
  }))

diff --git a/tests/pretty/hir-fn-variadic.pp b/tests/pretty/hir-fn-variadic.pp
@@ -9,7 +9,7 @@
 extern crate std;
 
 extern "C" {
- fn foo(x: i32, ...);
+ fn foo(x: i32, va1: ...);
 }
 
 unsafe extern "C" fn bar(_: i32, mut va2: ...) -> usize { va2.arg::<usize>() }