Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rationale: having a function which fails means that the location of failure which is output is that of the unreachable() function, rather than the caller. This is part of #8991 but is not all of it; current usage of ``std::util::unreachable()`` must remain so for the moment, until a new snapshot is made; then I will remove that function entirely in favour of using this macro.
- Loading branch information
6b7b8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at chris-morgan@6b7b8f2
6b7b8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging chris-morgan/rust/unreachable-macro = 6b7b8f2 into auto
6b7b8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chris-morgan/rust/unreachable-macro = 6b7b8f2 merged ok, testing candidate = d1dde99
6b7b8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1294
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1297
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/403
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/403
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1313
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/404
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/404
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1313
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/404
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/404
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/485
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1297
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/403
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/403
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1082
6b7b8f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d1dde99