Skip to content

Commit

Permalink
Add test for #8855
Browse files Browse the repository at this point in the history
  • Loading branch information
smoelius committed Aug 20, 2022
1 parent 5820add commit 6f3d398
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 1 deletion.
24 changes: 24 additions & 0 deletions tests/ui/format_args.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,27 @@ fn issue8643(vendor_id: usize, product_id: usize, name: &str) {
name
);
}

// https://github.com/rust-lang/rust-clippy/issues/8855
mod issue_8855 {
#![allow(dead_code)]

struct A {}

impl std::fmt::Display for A {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
write!(f, "test")
}
}

fn main() {
let a = A {};
let b = A {};

let x = format!("{} {}", a, b);
dbg!(x);

let x = format!("{:>6} {:>6}", a, b.to_string());
dbg!(x);
}
}
24 changes: 24 additions & 0 deletions tests/ui/format_args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,27 @@ fn issue8643(vendor_id: usize, product_id: usize, name: &str) {
name
);
}

// https://github.com/rust-lang/rust-clippy/issues/8855
mod issue_8855 {
#![allow(dead_code)]

struct A {}

impl std::fmt::Display for A {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
write!(f, "test")
}
}

fn main() {
let a = A {};
let b = A {};

let x = format!("{} {}", a, b.to_string());
dbg!(x);

let x = format!("{:>6} {:>6}", a, b.to_string());
dbg!(x);
}
}
8 changes: 7 additions & 1 deletion tests/ui/format_args.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,11 @@ error: `to_string` applied to a type that implements `Display` in `println!` arg
LL | println!("{foo}{bar}", bar = "bar", foo = "foo".to_string());
| ^^^^^^^^^^^^ help: remove this

error: aborting due to 21 previous errors
error: `to_string` applied to a type that implements `Display` in `format!` args
--> $DIR/format_args.rs:142:38
|
LL | let x = format!("{} {}", a, b.to_string());
| ^^^^^^^^^^^^ help: remove this

error: aborting due to 22 previous errors

0 comments on commit 6f3d398

Please sign in to comment.