Skip to content

Commit

Permalink
Rollup merge of #42330 - qnighy:macro-named-default, r=petrochenkov
Browse files Browse the repository at this point in the history
Parse macros named "default" correctly.

Fixes #42292.
  • Loading branch information
Mark-Simulacrum authored May 31, 2017
2 parents 0c339ff + b670930 commit 7f286a8
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 19 deletions.
42 changes: 23 additions & 19 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -698,24 +698,6 @@ impl<'a> Parser<'a> {
}
}

pub fn check_contextual_keyword(&mut self, ident: Ident) -> bool {
self.expected_tokens.push(TokenType::Token(token::Ident(ident)));
if let token::Ident(ref cur_ident) = self.token {
cur_ident.name == ident.name
} else {
false
}
}

pub fn eat_contextual_keyword(&mut self, ident: Ident) -> bool {
if self.check_contextual_keyword(ident) {
self.bump();
true
} else {
false
}
}

/// If the given word is not a keyword, signal an error.
/// If the next token is not the given word, signal an error.
/// Otherwise, eat it.
Expand Down Expand Up @@ -3755,6 +3737,28 @@ impl<'a> Parser<'a> {
self.look_ahead(1, |t| t.is_ident() && !t.is_any_keyword())
}

fn is_defaultness(&self) -> bool {
// `pub` is included for better error messages
self.token.is_keyword(keywords::Default) &&
self.look_ahead(1, |t| t.is_keyword(keywords::Impl) ||
t.is_keyword(keywords::Const) ||
t.is_keyword(keywords::Fn) ||
t.is_keyword(keywords::Unsafe) ||
t.is_keyword(keywords::Extern) ||
t.is_keyword(keywords::Type) ||
t.is_keyword(keywords::Pub))
}

fn eat_defaultness(&mut self) -> bool {
let is_defaultness = self.is_defaultness();
if is_defaultness {
self.bump()
} else {
self.expected_tokens.push(TokenType::Keyword(keywords::Default));
}
is_defaultness
}

fn eat_macro_def(&mut self, attrs: &[Attribute], vis: &Visibility)
-> PResult<'a, Option<P<Item>>> {
let lo = self.span;
Expand Down Expand Up @@ -5229,7 +5233,7 @@ impl<'a> Parser<'a> {

/// Parse defaultness: DEFAULT or nothing
fn parse_defaultness(&mut self) -> PResult<'a, Defaultness> {
if self.eat_contextual_keyword(keywords::Default.ident()) {
if self.eat_defaultness() {
Ok(Defaultness::Default)
} else {
Ok(Defaultness::Final)
Expand Down
27 changes: 27 additions & 0 deletions src/test/run-pass/macro-named-default.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

macro_rules! default {
($($x:tt)*) => { $($x)* }
}

default! {
struct A;
}

impl A {
default! {
fn foo(&self) {}
}
}

fn main() {
A.foo();
}

0 comments on commit 7f286a8

Please sign in to comment.