Skip to content

Commit

Permalink
Rollup merge of #114641 - kupiakos:ascii-char-to-not-as, r=scottmcm
Browse files Browse the repository at this point in the history
Rename copying `ascii::Char` methods from `as_` to `to_`

Tracking issue: #110998.

The [API guidelines][naming] describe `as_` as used for borrowed -> borrowed operations, and `to_` for
owned -> owned operations on `Copy` types.

[naming]: https://rust-lang.github.io/api-guidelines/naming.html
  • Loading branch information
matthiaskrgr authored Aug 9, 2023
2 parents e1cae5f + a22b9bf commit 83da317
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions library/core/src/ascii/ascii_char.rs
Original file line number Diff line number Diff line change
Expand Up @@ -518,14 +518,14 @@ impl AsciiChar {
/// Gets this ASCII character as a byte.
#[unstable(feature = "ascii_char", issue = "110998")]
#[inline]
pub const fn as_u8(self) -> u8 {
pub const fn to_u8(self) -> u8 {
self as u8
}

/// Gets this ASCII character as a `char` Unicode Scalar Value.
#[unstable(feature = "ascii_char", issue = "110998")]
#[inline]
pub const fn as_char(self) -> char {
pub const fn to_char(self) -> char {
self as u8 as char
}

Expand Down
4 changes: 2 additions & 2 deletions library/core/src/escape.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ impl<const N: usize> EscapeIterInner<N> {
}

pub fn next(&mut self) -> Option<u8> {
self.alive.next().map(|i| self.data[usize::from(i)].as_u8())
self.alive.next().map(|i| self.data[usize::from(i)].to_u8())
}

pub fn next_back(&mut self) -> Option<u8> {
self.alive.next_back().map(|i| self.data[usize::from(i)].as_u8())
self.alive.next_back().map(|i| self.data[usize::from(i)].to_u8())
}

pub fn advance_by(&mut self, n: usize) -> Result<(), NonZeroUsize> {
Expand Down

0 comments on commit 83da317

Please sign in to comment.