Skip to content

Commit

Permalink
Require module_id param to resolve to be non-empty
Browse files Browse the repository at this point in the history
Previously, `resolve` would immediately check that `module_id` was
non-empty and give an error if not. This had two downsides:

- It introduced `Option`s everywhere, even if the calling function knew
it had a valid module, and
- It checked the module on each namespace, which is unnecessary: it only
needed to be checked once.

This makes the caller responsible for checking the module exists, making
the code a lot simpler.
  • Loading branch information
jyn514 committed Sep 13, 2020
1 parent 7dc0d33 commit 8a13fc4
Showing 1 changed file with 279 additions and 295 deletions.
Loading

0 comments on commit 8a13fc4

Please sign in to comment.