Skip to content

Commit

Permalink
Add some FIXMEs for issue #607
Browse files Browse the repository at this point in the history
  • Loading branch information
brson committed Jul 1, 2011
1 parent 021b203 commit a34b61f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/comp/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ fn build_link_meta(&session::session sess, &ast::crate c,
sha.input_str(len_and_str(name));
}
case (ast::meta_list(_, _)) {
// FIXME (#607): Implement this
fail "unimplemented meta_item variant";
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/comp/front/attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ fn eq(@ast::meta_item a, @ast::meta_item b) -> bool {
}
}
case (ast::meta_list(?na, ?la)) {
// FIXME (#487): This involves probably sorting the list by name
// FIXME (#607): Needs implementing
// This involves probably sorting the list by name and
// meta_item variant
fail "unimplemented meta_item variant"
}
}
Expand All @@ -115,6 +117,7 @@ fn contains(&vec[@ast::meta_item] haystack, @ast::meta_item needle) -> bool {
ret false;
}

// FIXME: This needs to sort by meta_item variant in addition to the item name
fn sort_meta_items(&vec[@ast::meta_item] items) -> vec[@ast::meta_item] {
fn lteq(&@ast::meta_item ma, &@ast::meta_item mb) -> bool {
fn key(&@ast::meta_item m) -> ast::ident {
Expand Down

0 comments on commit a34b61f

Please sign in to comment.