Try to reduce false positives

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
rust-lang · Nov 11, 2023 · ad088ef · ad088ef
1 parent 1b53936
commit ad088ef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/compiler/rustc_parse/src/parser/diagnostics.rs b/compiler/rustc_parse/src/parser/diagnostics.rs
@@ -611,10 +611,12 @@ impl<'a> Parser<'a> {
         let mut err = self.struct_span_err(self.token.span, msg_exp);
 
         // Look for usages of '=>' where '>=' was probably intended
-        if self.token == token::FatArrow {
+        if self.token == token::FatArrow
+            && expected.iter().any(|tok| matches!(tok, TokenType::Token(TokenKind::Le)))
+        {
             err.span_suggestion(
                 self.token.span,
-                "you probably meant to write a \"greater than or equal to\" comparison",
+                "you might have meant to write a \"greater than or equal to\" comparison",
                 ">=",
                 Applicability::Unspecified,
             );

diff --git a/tests/ui/parser/eq-gt-to-gt-eq.rs b/tests/ui/parser/eq-gt-to-gt-eq.rs
@@ -1,4 +1,6 @@
+// run-rustfix
 // Check that we try to correct `=>` to `>=` in conditions.
+#![allow(unused)]
 
 fn main() {
     let a = 0;