-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #120148 - trevyn:issue-117965, r=cjgillot
`single_use_lifetimes`: Don't suggest deleting lifetimes with bounds Closes #117965 ``` 9 | pub fn get<'b: 'a>(&'b self) -> &'a str { | ^^ -- ...is used only here | | | this lifetime... ``` In this example, I think the `&'b self` can be replaced with the bound itself, yielding `&'a self`, but this would require a deeper refactor. Happy to do as a follow-on PR if desired.
- Loading branch information
Showing
3 changed files
with
36 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#![deny(single_use_lifetimes)] | ||
|
||
pub enum Data<'a> { | ||
Borrowed(&'a str), | ||
Owned(String), | ||
} | ||
|
||
impl<'a> Data<'a> { | ||
pub fn get<'b: 'a>(&'b self) -> &'a str { | ||
//~^ ERROR lifetime parameter `'b` only used once | ||
match &self { | ||
Self::Borrowed(val) => val, | ||
Self::Owned(val) => &val, | ||
} | ||
} | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
error: lifetime parameter `'b` only used once | ||
--> $DIR/issue-117965.rs:9:16 | ||
| | ||
LL | pub fn get<'b: 'a>(&'b self) -> &'a str { | ||
| ^^ -- ...is used only here | ||
| | | ||
| this lifetime... | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/issue-117965.rs:1:9 | ||
| | ||
LL | #![deny(single_use_lifetimes)] | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 1 previous error | ||
|