Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mk: Clean just one llvm build at a time. Closes #17852
When building for multiple targets, the initial 'make' invocation always fails. The missing build stamp causes clean-llvm to be invoked, but clean-llvm cleans *all* llvm builds. So what happens is that 1) all llvm's are cleaned (a no-op), 2) llvm-${target1} builds, 3) all llvm's are cleaned (deleting llvm-${target1}), 4) llvm-${target2} is built, 5) the remaining build for ${target1} fails because llvm does not exist. This makes the clean operation only clean the correct llvm build. Should greatly reduce bot failures.
- Loading branch information
b8e7c4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at brson@b8e7c4f
b8e7c4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging brson/rust/clean-llvm = b8e7c4f into auto
b8e7c4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brson/rust/clean-llvm = b8e7c4f merged ok, testing candidate = d1fc2de
b8e7c4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2011
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2010
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2003
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2010
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2005
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2004
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2004
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2008
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2001
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2001
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2004
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1661
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1654
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1662
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/500
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/496
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/489
b8e7c4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d1fc2de