Skip to content

Commit

Permalink
Disable both reproducible-build tests for crate-type=bin
Browse files Browse the repository at this point in the history
These tests fail on Windows, as the build is not deterministic there for
bin targets.

Issue #88982 is filed for this
problem.
  • Loading branch information
danakj committed Sep 15, 2021
1 parent 4933be9 commit c011828
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 14 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -534,11 +534,6 @@ jobs:
strategy:
matrix:
include:
- name: x86_64-msvc-1
env:
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-profiler"
SCRIPT: make ci-subset-1
os: windows-latest-xl
- name: dist-x86_64-linux
os: ubuntu-latest-xl
env: {}
Expand Down
5 changes: 0 additions & 5 deletions src/ci/github-actions/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -668,11 +668,6 @@ jobs:
strategy:
matrix:
include:
- name: x86_64-msvc-1
env:
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-profiler
SCRIPT: make ci-subset-1
<<: *job-windows-xl
- *dist-x86_64-linux

master:
Expand Down
9 changes: 5 additions & 4 deletions src/test/run-make-fulldeps/reproducible-build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@ all: \
opt \
link_paths \
remap_paths \
different_source_dirs_bin \
different_source_dirs_rlib \
remap_cwd_rlib \
remap_cwd_to_empty \
extern_flags

# TODO: Deterministic builds of `bin` crate types are not deterministic with
# debuginfo=2 on Windows.
# See https://github.com/rust-lang/rust/pull/87320#issuecomment-920105533
# TODO: Builds of `bin` crate types are not deterministic with debuginfo=2 on
# Windows.
# See: https://github.com/rust-lang/rust/pull/87320#issuecomment-920105533
# Issue: https://github.com/rust-lang/rust/issues/88982
#
# different_source_dirs_bin \
# remap_cwd_bin \
Expand Down

0 comments on commit c011828

Please sign in to comment.