Skip to content

Commit

Permalink
Rollup merge of #131776 - hoodmane:emscripten-xfail-backtrace-tests, …
Browse files Browse the repository at this point in the history
…r=jieyouxu

Emscripten: Xfail backtrace ui tests

It is possible to link libunwind and use the normal backtrace code, but it fails to symbolize stack traces. I investigated and could get the list of instruction pointers and symbol names, but I'm not sure how to use the dwarf info to map from instruction pointer to source location. In any case, fixing this is not a high priority.

See #131738

r?jieyouxu
  • Loading branch information
matthiaskrgr authored Oct 16, 2024
2 parents 80cbc6d + 476ea45 commit c8ec8e6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/ui/backtrace/dylib-dep.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
//@ ignore-musl musl doesn't support dynamic libraries (at least when the original test was written).
//@ needs-unwind
//@ compile-flags: -g -Copt-level=0 -Cstrip=none -Cforce-frame-pointers=yes
//@ ignore-emscripten Requires custom symbolization code
//@ aux-crate: dylib_dep_helper=dylib-dep-helper.rs
//@ aux-crate: auxiliary=dylib-dep-helper-aux.rs
//@ run-pass
Expand Down
1 change: 1 addition & 0 deletions tests/ui/backtrace/line-tables-only.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
//@ compile-flags: -Cstrip=none -Cdebuginfo=line-tables-only
//@ ignore-android FIXME #17520
//@ ignore-fuchsia Backtraces not symbolized
//@ ignore-emscripten Requires custom symbolization code
//@ needs-unwind
//@ aux-build: line-tables-only-helper.rs

Expand Down

0 comments on commit c8ec8e6

Please sign in to comment.