Skip to content

Commit

Permalink
Rollup merge of #81897 - vandenheuvel:match_exhaustive_diagnostics_re…
Browse files Browse the repository at this point in the history
…gression_test, r=Mark-Simulacrum

Add match pattern diagnostics regression test

Closes #72377 by adding a regression test.

This test case fails on stable but now works on beta and nightly. It *should* have worked already for years, the crucial point whether it is mentioned that some uncovered patterns are not explicitly mentioned.
  • Loading branch information
jonas-schievink authored Feb 15, 2021
2 parents f02f7b0 + 5fe8490 commit cd27820
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/test/ui/pattern/usefulness/issue-72377.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#[derive(PartialEq, Eq)]
enum X { A, B, C, }

fn main() {
let x = X::A;
let y = Some(X::A);

match (x, y) {
//~^ ERROR non-exhaustive patterns: `(A, Some(A))`, `(A, Some(B))`, `(B, Some(B))` and 2
//~| more not covered
(_, None) => false,
(v, Some(w)) if v == w => true,
(X::B, Some(X::C)) => false,
(X::B, Some(X::A)) => false,
(X::A, Some(X::C)) | (X::C, Some(X::A)) => false,
};
}
12 changes: 12 additions & 0 deletions src/test/ui/pattern/usefulness/issue-72377.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
error[E0004]: non-exhaustive patterns: `(A, Some(A))`, `(A, Some(B))`, `(B, Some(B))` and 2 more not covered
--> $DIR/issue-72377.rs:8:11
|
LL | match (x, y) {
| ^^^^^^ patterns `(A, Some(A))`, `(A, Some(B))`, `(B, Some(B))` and 2 more not covered
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `(X, Option<X>)`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0004`.

0 comments on commit cd27820

Please sign in to comment.