Skip to content

Commit

Permalink
Rollup merge of #106676 - oli-obk:tait_test, r=dtolnay
Browse files Browse the repository at this point in the history
Test that we cannot use trait impl methods arguments as defining uses

Addresses #63063 (comment)

r? `@dtolnay`
  • Loading branch information
matthiaskrgr authored Jan 12, 2023
2 parents db8301b + 44a5ce6 commit d42d952
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 0 deletions.
24 changes: 24 additions & 0 deletions tests/ui/type-alias-impl-trait/unnameable_type.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#![feature(type_alias_impl_trait)]

// This test ensures that unnameable types stay unnameable
// https://github.com/rust-lang/rust/issues/63063#issuecomment-1360053614

// library
mod private {
pub struct Private;
pub trait Trait {
fn dont_define_this(_private: Private) {}
}
}

use private::Trait;

// downstream
type MyPrivate = impl Sized;
//~^ ERROR: unconstrained opaque type
impl Trait for u32 {
fn dont_define_this(_private: MyPrivate) {}
//~^ ERROR: incompatible type for trait
}

fn main() {}
31 changes: 31 additions & 0 deletions tests/ui/type-alias-impl-trait/unnameable_type.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
error: unconstrained opaque type
--> $DIR/unnameable_type.rs:17:18
|
LL | type MyPrivate = impl Sized;
| ^^^^^^^^^^
|
= note: `MyPrivate` must be used in combination with a concrete type within the same module

error[E0053]: method `dont_define_this` has an incompatible type for trait
--> $DIR/unnameable_type.rs:20:35
|
LL | type MyPrivate = impl Sized;
| ---------- the found opaque type
...
LL | fn dont_define_this(_private: MyPrivate) {}
| ^^^^^^^^^
| |
| expected struct `Private`, found opaque type
| help: change the parameter type to match the trait: `Private`
|
note: type in trait
--> $DIR/unnameable_type.rs:10:39
|
LL | fn dont_define_this(_private: Private) {}
| ^^^^^^^
= note: expected signature `fn(Private)`
found signature `fn(MyPrivate)`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0053`.

0 comments on commit d42d952

Please sign in to comment.