Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rustc: Get LLVM error message safely
On Windows, `LLVMRustGetLastError()` may return non-utf8 mojibake string if system uses non-English locale. It caused ICE when llvm fails. This patch doesn't fix the real problem, but just make rustc not die.
- Loading branch information
f6afd40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at klutzy@f6afd40
f6afd40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging klutzy/rust/this-is-windows = f6afd40 into auto
f6afd40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
klutzy/rust/this-is-windows = f6afd40 merged ok, testing candidate = 987de29
f6afd40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4614
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/2456
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/2456
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4611
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3711
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3717
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4627
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3715
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3721
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4629
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3715
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3720
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3788
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1606
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4623
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3724
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3731
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4388
f6afd40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 987de29