Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is a Windows specific fix in libc. According to MSDN, the GUID
structure's Data2 and Data3 members expect WORD types instead of DWORD. I discovered this discrepancy while experimenting with some bindings to Microsoft's OLE2 api. The discrepancy was corrupting the contents of the string returned by UuidToString after I used known GUIDs to test the accuracy of the function binding. I didn't add test cases because it would mean adding a dependency to my rather incomplete binding library. However, the fix produces expected string values when tested.
- Loading branch information
fc4c6ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at iancormac84@fc4c6ee
fc4c6ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging iancormac84/rust/libc_windows_guid_fix = fc4c6ee into auto
fc4c6ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iancormac84/rust/libc_windows_guid_fix = fc4c6ee merged ok, testing candidate = 1fd7de8
fc4c6ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5292
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5288
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4381
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4394
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5390
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4477
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4485
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5392
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4477
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4483
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4547
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2277
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5387
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4484
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4497
fc4c6ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 1fd7de8