You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rustc_const_eval::util module consists of functions that are never used inside rustc_const_eval, nor do they need any other part of this crate, so these are at the wrong location -- looks like a mistake that was introduced when rustc_mir was split up a while ago, and/or as part of the later split of rustc_mir_transform.
Cc @rust-lang/wg-const-eval @cjgillot
Any suggestions for where this code belongs instead? Some of these are exclusively used by rustc_mir_transform, so they could go there. Some are also used by rustc_borrowck, so I am not sure what the best location is for them. I just know rustc_const_eval is definitely wrong. :)
The text was updated successfully, but these errors were encountered:
IIRC, I put these methods there because rustc_const_eval was the most downstream crate that both rustc_borrowck and rustc_mir_transform depended on. I know this is wrong, but I did not really know of a better place.
The
rustc_const_eval::util
module consists of functions that are never used inside rustc_const_eval, nor do they need any other part of this crate, so these are at the wrong location -- looks like a mistake that was introduced when rustc_mir was split up a while ago, and/or as part of the later split of rustc_mir_transform.Cc @rust-lang/wg-const-eval @cjgillot
Any suggestions for where this code belongs instead? Some of these are exclusively used by rustc_mir_transform, so they could go there. Some are also used by rustc_borrowck, so I am not sure what the best location is for them. I just know
rustc_const_eval
is definitely wrong. :)The text was updated successfully, but these errors were encountered: