Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc on error always prints the same two "task failed" lines #10036

Closed
ben0x539 opened this issue Oct 23, 2013 · 2 comments
Closed

rustc on error always prints the same two "task failed" lines #10036

ben0x539 opened this issue Oct 23, 2013 · 2 comments

Comments

@ben0x539
Copy link
Contributor 

task '<unnamed>' failed at 'explicit failure', /build/rust-git/src/rust/src/libsyntax/diagnostic.rs:101
task '<unnamed>' failed at 'explicit failure', /build/rust-git/src/rust/src/librustc/rustc.rs:395

It's more messy than informative, isn't it?

This might go away when rustc stops unwinding and just aborts, but I wonder whether we oughtn't have some way to suppress those messages, since I imagine a lot of commandliney programs that use unwinding won't want to expose their internal task failures to the console, unless they're tearing down the entire runtime with linked failure.
@alexcrichton
Copy link
Member

This is actually a general problem in that when a task fails it will forcibly log the error to the task's logger. With #9967 coming down the pipe soon, I believe that the way forward with this is to have the message get propagated to the parent who then decides what to do with it.

For rustc specifically, all of the monitored tasks wouldn't print their failure, the parents would receive the failure and then just ignore it (or print the ICE message).

@ben0x539
Copy link
Contributor Author

I don't think this is an issue anymore.

bors pushed a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@DorianListens
fix: Extract function from trait impl
e394000 
This change fixes rust-lang#10036, "Extract to function assist implements nonexistent
trait methods".

When we detect that the extraction is coming from within a trait impl, and that
a `self` param will be necessary, we adjust which `SyntaxNode` to `insert_after`,
and create a new empty `impl` block for the newly extracted function.
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12676 - DorianListens:dscheidt/extract-fun-tr…
7181a39 
…ait-impl, r=jonas-schievink

fix: Extract function from trait impl

This change fixes rust-lang#10036, "Extract to function assist implements nonexistent
trait methods".

When we detect that the extraction is coming from within a trait impl, and that
a `self` param will be necessary, we adjust which `SyntaxNode` to `insert_after`,
and create a new empty `impl` block for the newly extracted function.
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#10036 - rust-lang:flip1995/labels, r=xFrednet
d18f31e 
Add beta-nominated label to triagebot

Also non-maintainers should be able to label PRs with `beta-nominated`.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ben0x539 @alexcrichton