-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: transmute_copy validates sizing #100545
Comments
I believe this is the same as #99923 Edit: I meant "the same category as". |
Seems like a much easier issue to explain, at least - not sure I would quite call it "same as" pointer/integer transmutes :) Though the overall effect of breaking unsafe code seems quite similar. |
The issues seem entirely unrelated to me, in which sense are they "the same"? |
Or did you mean they are broadly the same category, being related to UB detection? But even then, #99923 is about compile-time UB, and this here is primarily about run-time UB, and those are very different in how we treat them. |
The easiest justification for the panic is " Maybe also mention |
Yeah, we could have a |
transmute_copy
now validates reasonable sizes and panics if not as of #98839, this causes some breakage (detected at the time in #98839 (comment)).Mostly filing this issue to make sure we add a release notes compat note about this, but I don't expect us to do anything further. Nominating for T-libs-api, though, mostly just for awareness.
cc @tmandry / @joshtriplett -- let's make sure this makes it into 1.64 release notes
The text was updated successfully, but these errors were encountered: