Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustpkg invokes rustc without going through rustc::monitor #10104

Closed
jld opened this issue Oct 27, 2013 · 3 comments
Closed

rustpkg invokes rustc without going through rustc::monitor #10104

jld opened this issue Oct 27, 2013 · 3 comments

Comments

@jld
Copy link
Contributor

jld commented Oct 27, 2013

This may be a bigger problem, but one concrete effect (seen in #9613) is that rustpkg doesn't set the larger-than-default stack size that rustc would normally get. (The spawn responsible for that is actually in extra::workcache, not rustpkg itself, and it doesn't take a task builder — if I edit workcache to set a stack size then the tests pass but that's probably not the right solution.)

@catamorphism
Copy link
Contributor

I've implemented this change, but I don't know how to test it. I thought at first I would start using the diagnostic emitter to print out errors in rustpkg, and then a test could check the error message to make sure it was formatted right (since the demitter can only come from monitor). But, the @Emitter is non-sendable, and rustpkg does everything in tasks, so that won't work.

I'm just going to submit the PR without a test.

@catamorphism
Copy link
Contributor

This is actually kind of annoying -- see my comment on #10342

@thestinger
Copy link
Contributor

rustpkg is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants