Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the status messages emitted by bootstrap more clear #102003

Closed
jyn514 opened this issue Sep 19, 2022 · 3 comments
Closed

Make the status messages emitted by bootstrap more clear #102003

jyn514 opened this issue Sep 19, 2022 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 19, 2022

I'm currently having an extended discussion in https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Stage.20numbering.20for.20tools about what the stage numbering for bootstrap means and how it should work. Part of the confusion, as pointed out by @the8472, is that it's unclear whether "Building stage1 std artifacts" refers to the compiler being run or the artifact being created. We should make this more clear by printing "Building stage1 std using stage0-sysroot".

(the names are kind of weird for now; #101961 will help with this.)

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Sep 19, 2022
@jyn514
Copy link
Member Author

jyn514 commented Sep 19, 2022

This is "easy" but a lot of work; these messages are printed in a lot of different places across bootstrap and it's going to be a lot of manual work to update them all. #86022 had some WIP effort to make the status message autogenerated, but that will likely be even more work than updating the messages by hand.

@jyn514 jyn514 self-assigned this Nov 5, 2022
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Nov 6, 2022
…mulacrum

Print "Checking/Building ..." message even when --dry-run is passed

Print "Checking/Building ..." message even when --dry-run is passed

This makes it a lot easier to understand what commands will be run without
having to parse the `-vv` output, which isn't meant to be user facing.

I also want to change these messages at some point (rust-lang#102003) and this change will make it easier to paste a before/after comparison without having to actually build a stage 2 compiler.
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 12, 2022
…mulacrum

Print "Checking/Building ..." message even when --dry-run is passed

Print "Checking/Building ..." message even when --dry-run is passed

This makes it a lot easier to understand what commands will be run without
having to parse the `-vv` output, which isn't meant to be user facing.

I also want to change these messages at some point (rust-lang#102003) and this change will make it easier to paste a before/after comparison without having to actually build a stage 2 compiler.
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 13, 2022
…lacrum

Print "Checking/Building ..." message even when --dry-run is passed

Print "Checking/Building ..." message even when --dry-run is passed

This makes it a lot easier to understand what commands will be run without
having to parse the `-vv` output, which isn't meant to be user facing.

I also want to change these messages at some point (rust-lang#102003) and this change will make it easier to paste a before/after comparison without having to actually build a stage 2 compiler.
@jyn514 jyn514 removed their assignment Dec 20, 2022
@jyn514
Copy link
Member Author

jyn514 commented Dec 20, 2022

An example change:

diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs
index 24b033cc0dc..b8ea072e584 100644
--- a/src/bootstrap/tool.rs
+++ b/src/bootstrap/tool.rs
@@ -70,7 +70,17 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
             &self.extra_features,
         );
 
-        builder.info(&format!("Building stage{} tool {} ({})", compiler.stage, tool, target));
+        let msg = if self.mode == Mode::ToolRustc {
+            format!(
+                "Building stage {} tool {tool} using stage {} sysroot ({target})",
+                compiler.stage + 1,
+                compiler.stage
+            )
+        } else {
+            format!("Building tool {tool} using stage {} sysroot ({target})", compiler.stage)
+        };
+        builder.info(&msg);
+
         let mut duplicates = Vec::new();
         let is_expected = compile::stream_cargo(builder, cargo, vec![], &mut |msg| {
             // Only care about big things like the RLS/Cargo for now

@jyn514
Copy link
Member Author

jyn514 commented Apr 29, 2023

fixed in #108171 (lol apparently i opened the same issue twice)

@jyn514 jyn514 closed this as completed Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

1 participant