Rustpkg can't install dependencies that use the src/foo/lib.rs structure

[sfackler]

If I take a project like https://github.com/steveklabnik/hello, I can manually install via rustpkg just fine:

~/test ❯ env TMPDIR=$HOME/tmp rustpkg install github.com/steveklabnik/hello
WARNING: The Rust package manager is experimental and may be unstable
note: Installed package github.com/steveklabnik/hello-0.1 to /home/sfackler/test/.rust

But, if I have a project that depends on hello:

extern mod hello = "github.com/steveklabnik/hello";

fn main() {}

It can't properly pull in the hello dependency:

~/test ❯ env TMPDIR=$HOME/tmp rustpkg install foo
WARNING: The Rust package manager is experimental and may be unstable
task '<unnamed>' failed at 'assertion failed: os::path_exists(&pkg_src.start_dir.join(p))', /home/sfackler/rust/rust/src/librustpkg/lib.rs:516
task '<unnamed>' failed at 'receiving on closed channel', /home/sfackler/rust/rust/src/libstd/rt/comm.rs:198

The full debug output dump is here: http://sprunge.us/SRPU but the gist of it is that it has start_dir = /home/sfackler/test/.rust/build/x86_64-unknown-linux-gnu/src/github.com/steveklabnik/hello-0.1 and JustOne: p = lib.rs, which is missing the src/hello indirection.

A package like https://github.com/sfackler/rust-postgres that has lib.rs in the root directory works just fine.

cc @catamorphism

[sfackler]

Some packages like https://github.com/brson/rust-sdl fail to work even with rustpkg install with the same error.

[Aatch]

I encountered a similar (possibly same, at least the same assertion) using rustpkg build to retrieve dependencies.

[catamorphism]

I have a fix for this, well, sort of -- at least it fixes the ICE. I'm just writing a test for it now.

[eholk]

Does rustpkg require Github repos to have the same name as the crate inside? For example, can my rust-papi repo define a papi crate, or does the crate have to be called rust-papi?