Skip to content

Add consistent feature gating for bootstrap #102600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyn514 opened this issue Oct 2, 2022 · 2 comments
Open

Add consistent feature gating for bootstrap #102600

jyn514 opened this issue Oct 2, 2022 · 2 comments
Assignees
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 2, 2022

Currently, we have a several "best-effort" features in bootstrap, which aren't really supported, but we have code for since they're impossible to do otherwise. x.py fix, x.py clippy, and x.py test --stage 0 src/test/ui are some examples. Currently, only the last one has a feature gate: by default it gives a hard error ("this tests the beta compiler, you probably don't want that") but it lets you override that with COMPILETEST_FORCE_STAGE0=1. We should extend that to other parts of bootstrap, and use a consistent mechanism to enable the features - @Mark-Simulacrum suggested something like bootstrap-features = ["xyz"] in config.toml.

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 2, 2022
@onur-ozkan onur-ozkan self-assigned this Jan 3, 2024
@onur-ozkan
Copy link
Member

Implementing #112679 first would be quite beneficial. We don't have do hacky tricks to handle stage-specific bootstrap features after that.

@rustbot blocked

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2024

Error: The "Blocked" shortcut only works on pull requests.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@onur-ozkan onur-ozkan added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants