Is exact count of other implementations useful in this error message? #102864
Labels
A-contributor-roadblock
Area: Makes things more difficult for new or seasoned contributors to Rust
A-diagnostics
Area: Messages for errors, warnings, and lints
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
D-papercut
Diagnostics: An error or lint that needs small tweaks.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
I got the following CI failure in #102862
I don't know if this is a diagnostics request or a UI test normalization request, but getting UI test failures when adding a
From
implementation is kinda annoying (if admittedly easy enough to fix).So I wonder how much value the exact number here is providing. I wonder if it might make sense to change the message to
if it's above some threshold.
I can't see any reason the exact count is useful to the programmer reading the error (at least when it's a large number), and it might save some work in error message generation to stop once it's found a bunch.
The text was updated successfully, but these errors were encountered: