Skip to content

Tracking issue for -Z instrument-xray #102921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
ilammy opened this issue Oct 11, 2022 · 1 comment
Open
1 of 3 tasks

Tracking issue for -Z instrument-xray #102921

ilammy opened this issue Oct 11, 2022 · 1 comment
Labels
A-CLI Area: Command-line interface (CLI) to the compiler C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ilammy
Copy link
Contributor

ilammy commented Oct 11, 2022 •
edited
Loading

This is a tracking issue for -Z instrument-xray flag, enabling XRay instrumentation support.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Do we want to stabilize this at all? That will be know after the unstable option sees some use.

Implementation history
@ilammy ilammy added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Oct 11, 2022
@workingjubilee workingjubilee added the A-CLI Area: Command-line interface (CLI) to the compiler label Mar 5, 2023
@csmoe
Copy link
Member

csmoe commented Sep 11, 2023 •
edited
Loading

https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems xray was ported to mac recently, should we enable it on those targets? And maybe we should bundle the llvm xray runtime as asan/tsan along with rustup.

@quininer quininer mentioned this issue May 8, 2025
Merged
@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 9, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#140790 - quininer:mac-xray, r=jieyouxu
8eb7f8f 
Enable xray support for Mac

rust-lang#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31
bors added a commit that referenced this issue May 24, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=jieyouxu
d1037a7 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31
bors added a commit that referenced this issue May 24, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=<try>
ac49629 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple-1
bors added a commit that referenced this issue May 24, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=<try>
d71beba 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
bors added a commit that referenced this issue May 25, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=jieyouxu
08c9e3c 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
bors added a commit that referenced this issue May 25, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=<try>
8803ee0 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
bors added a commit that referenced this issue May 25, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=<try>
19349e1 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
bors added a commit that referenced this issue May 25, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=<try>
1ad0547 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
bors added a commit that referenced this issue May 26, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=wesleywiser,jieyouxu
d76fe15 
Enable xray support for Mac

#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
github-actions bot pushed a commit to rust-lang/miri that referenced this issue May 27, 2025
@bors
Auto merge of #140790 - quininer:mac-xray, r=wesleywiser,jieyouxu
699a4f5 
Enable xray support for Mac

rust-lang/rust#102921

Upstream has supported Mac for a while, let's enable it.

I've tested it on M4 and it generates nop sled correctly.

* https://maskray.me/blog/2023-06-18-port-llvm-xray-to-apple-systems
* https://github.com/llvm/llvm-project/blob/llvmorg-20.1.4/clang/lib/Driver/XRayArgs.cpp#L31

try-job: x86_64-apple-1
try-job: aarch64-apple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CLI Area: Command-line interface (CLI) to the compiler C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ilammy @csmoe @jieyouxu @workingjubilee