Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: source code viewer sometimes has extra scroll bar #106455

Closed
kadiwa4 opened this issue Jan 4, 2023 · 0 comments · Fixed by #107266
Closed

rustdoc: source code viewer sometimes has extra scroll bar #106455

kadiwa4 opened this issue Jan 4, 2023 · 0 comments · Fixed by #107266
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@kadiwa4
Copy link
Contributor

kadiwa4 commented Jan 4, 2023

Notice the vertical scroll bar (on the right) where there isnt supposed to be one and the unaligned line numbers (because I scrolled):
Screenshot 2023-01-04 at 16 53 01

The issue is easier to replicate for long source files.

Rust version: 1.59.0 and upwards

Replicating

macOS 13.1 / Safari 16.2

Open https://doc.rust-lang.org/1.66.0/src/core/num/uint_macros.rs.html; make sure the sidebar is expanded. Reload until you see the problematic scroll bar.

@rustbot label: +A-rustdoc-ui +C-bug +T-rustdoc
@rustbot rustbot added A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 4, 2023
@kadiwa4 kadiwa4 mentioned this issue Jan 24, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#107266 - kadiwa4:source_viewer_scrollbar, r…
2c432b6 
…=notriddle

rustdoc: prohibit scroll bar on source viewer in Safari

Fixes rust-lang#106455.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#107266 - kadiwa4:source_viewer_scrollbar, r…
7cede15 
…=notriddle

rustdoc: prohibit scroll bar on source viewer in Safari

Fixes rust-lang#106455.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#107266 - kadiwa4:source_viewer_scrollbar, r…
f268c7b 
…=notriddle

rustdoc: prohibit scroll bar on source viewer in Safari

Fixes rust-lang#106455.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: prohibit scroll bar on source viewer in Safari kadiwa4/rust
2 participants
@kadiwa4 @rustbot