-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer hex literals should perhaps not consider signededness #10713
Comments
Why shouldn't that produce a warning? Are hex literals somehow magic? I would expect to have to say either |
Closing, general opinion is opposite of mine, I think I'm just special in this regard. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 5, 2023
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 5, 2023
…rted_modules, r=Alexendoo Fix `items_after_test_module`: Ignore imported modules Fixes rust-lang#10713. It does a little bit of dark magic, but intention is what really counts. changelog:[`items_after_test_module`]: Ignore imported modules (`mod foo;`) with no body.
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jun 30, 2023
`items_after_test_module`: Ignore in-proc-macros items The library `test-case` is having some problems with this lint, ignoring proc macros should fix it. Related to rust-lang#10713 and frondeus/test-case#122 (Couldn't add test cases for this exact situation without importing the library, but I think the fix is simple enough that we can be pretty sure there won't be any problems :) ) changelog:[`items_after_test_module`]: Ignore items in procedural macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would not expect this code to produce a warning:
Although the following warnings are printed
The text was updated successfully, but these errors were encountered: