Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording during bootstrap is inconsistent #107230

Closed
albertlarsan68 opened this issue Jan 23, 2023 · 1 comment · Fixed by #107332
Closed

Wording during bootstrap is inconsistent #107230

albertlarsan68 opened this issue Jan 23, 2023 · 1 comment · Fixed by #107332
Assignees
@chansuke
Labels
D-inconsistent Diagnostics: Inconsistency in formatting, grammar or style between diagnostic messages. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@albertlarsan68
Copy link
Member

albertlarsan68 commented Jan 23, 2023 •
edited by rustbot
Loading

When running almost any x command, it prints Building rustbuild, but then Cargo says Finished bootstrap.
There should be only one denomination used, and I think that bootstrap is the better one.
@albertlarsan68 albertlarsan68 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) D-inconsistent Diagnostics: Inconsistency in formatting, grammar or style between diagnostic messages. labels Jan 23, 2023
@chansuke
Copy link
Contributor

@rustbot claim

@chansuke chansuke mentioned this issue Jan 26, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jan 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#107332 - chansuke:issue-107230, r=albertlar…
2fa25bf 
…san68

Fix wording from `rustbuild` to `bootstrap`

Fixes rust-lang#107230
@bors bors closed this as completed in 1e0cf72 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chansuke chansuke

Labels
D-inconsistent Diagnostics: Inconsistency in formatting, grammar or style between diagnostic messages. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wording from rustbuild to bootstrap chansuke/rust
2 participants
@chansuke @albertlarsan68