Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Ztrait-solver=next: add remaining builtin impl candidates #107379

Closed
lcnr opened this issue Jan 27, 2023 · 5 comments
Closed

-Ztrait-solver=next: add remaining builtin impl candidates #107379

lcnr opened this issue Jan 27, 2023 · 5 comments
Assignees
Labels
E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Comments

@lcnr
Copy link
Contributor

lcnr commented Jan 27, 2023

see #107374 for which candidates are missing. It should be Destruct and Transmute

How to add a new builtin candidate

see #107282 as a reference.

to figure out how your builtin impl should work, you can take the old impl as a reference.
Using DiscriminantKind as an example the old solver deals with builtin candidates in the following places:

Further help

In case you want to work on this and would like further help or are stuck, feel free to open a thread in https://rust-lang.zulipchat.com/#narrow/stream/364551-t-types.2Ftrait-system-refactor or pm me directly on zulip if that's more comfortable for you.

@lcnr lcnr added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 27, 2023
@lcnr lcnr changed the title '-Ztrait-solver=next`: add remaining builtin impl candidates -Ztrait-solver=next: add remaining builtin impl candidates Jan 27, 2023
@detrumi
Copy link
Member

detrumi commented Jan 27, 2023

@rustbot claim

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Feb 3, 2023
…=compiler-errors

Add candidates for DiscriminantKind builtin

Part of rust-lang#107379
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Feb 3, 2023
…=compiler-errors

Add candidates for DiscriminantKind builtin

Part of rust-lang#107379
@ndrewxie
Copy link
Contributor

ndrewxie commented Apr 8, 2023

I'd like to try - I'll take a more detailed look tomorrow to see which parts detrumi finished already and which parts remain.
No guarantees I'll succeed but hey

@rustbot claim

@lcnr
Copy link
Contributor Author

lcnr commented Apr 10, 2023

@ndrewxie i think this issue has sadly already been resolved 😅 🤔

Destruct has been implemented in #109495 and @compiler-errors has recently opened a PR for Transmute #110126

@compiler-errors
Copy link
Member

Sorry haha. Closing for now.

@ndrewxie
Copy link
Contributor

@ndrewxie i think this issue has sadly already been resolved 😅 🤔

Destruct has been implemented in #109495 and @compiler-errors has recently opened a PR for Transmute #110126

Yeahhh I saw the destruct thing already

It's okay, I'll just find smth else to work on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

No branches or pull requests

4 participants