Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old docs appear under /doc/master/ng/... on the website #10896

Closed
huonw opened this issue Dec 10, 2013 · 3 comments
Closed

Old docs appear under /doc/master/ng/... on the website #10896

huonw opened this issue Dec 10, 2013 · 3 comments

Comments

@huonw
Copy link
Member

huonw commented Dec 10, 2013

e.g. http://static.rust-lang.org/doc/master/ng/std/index.html

They should be removed.
@emberian
Copy link
Member

False positive, due to browser caching.

@huonw
Copy link
Member Author

huonw commented Dec 10, 2013

Fixed, thanks @alexcrichton.

@adrientetar
Copy link
Contributor

@huonw I think I've got a similar situation:
http://static.rust-lang.org/doc/master/src/extra/home/rustbuild/src/rust-buildbot/slave/doc/build/src/libextra/fileinput.rs.html

@adrientetar adrientetar mentioned this issue Dec 15, 2013
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10896 - y21:eager-or-lazy-autoderef, r=blyxya…
7c34ec8 
…s,xFrednet

consider autoderef through user-defined `Deref` in `eager_or_lazy`

Fixes rust-lang#10462

This PR handles autoderef in the `eager_or_lazy` util module and stops suggesting to change lazy to eager if autoderef in an expression goes through user defined `Deref` impls, e.g.
```rs
struct S;
impl Deref for S {
  type Target = ();
  fn deref(&self) -> &Self::Target { &() }
}

let _ = Some(()).as_ref().unwrap_or_else(|| &S); // autoderef `&S` -> `&()`
```

changelog: [`unnecessary_lazy_evaluations`]: don't suggest changing lazy evaluation to eager if autoderef goes through user-defined `Deref`

r? `@xFrednet`  (because of the earlier review in rust-lang#10864, might help for context here)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emberian @huonw @adrientetar