Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out-of-range float literals are not checked by type-limits lint #10934

Closed
huonw opened this issue Dec 12, 2013 · 2 comments
Closed

Out-of-range float literals are not checked by type-limits lint #10934

huonw opened this issue Dec 12, 2013 · 2 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@huonw
Copy link
Member

huonw commented Dec 12, 2013

e.g.

fn main() { println!("{} {}", 1e310, 1e-360 == 0.0); } // prints `inf true`.
@hirschenberger hirschenberger mentioned this issue May 22, 2014
Closed
@hirschenberger
Copy link
Contributor

I worked on this but unforunately rust's from_str_bytes_common which I have to use for parsing the string representation of ast::LitFloat fails parsing f32::MAX_VALUE and friends.
See #14353 for the issue.

@hirschenberger hirschenberger mentioned this issue May 29, 2014
Merged
hirschenberger added a commit to hirschenberger/rust that referenced this issue Jul 7, 2014
@hirschenberger
Add range lint for float literals, fixing rust-lang#10934
e591261
hirschenberger added a commit to hirschenberger/rust that referenced this issue Jul 10, 2014
@hirschenberger
Add range lint for float literals, fixing rust-lang#10934
f8bc571
bors added a commit that referenced this issue Jul 10, 2014
@bors
auto merge of #14519 : hirschenberger/rust/issue-10934, r=alexcrichton
345886c 
Issue #10934
@alexcrichton
Copy link
Member

Closed by #14519, thanks @hirschenberger!

flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10934 - Centri3:single_range_in_vec_init, r=g…
823d9dd 
…iraffate

new lint [`single_range_in_vec_init`]

Lints on `vec![0..200]` (or `[0..200]`), suggesting either `(0..200).collect::<Vec<i32>>()` or `[0; 200]`.

Haven't tested it with anything that isn't primitive. Probably should!

Closes rust-lang#10932

changelog: new lint [`single_range_in_vec_init`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @hirschenberger @huonw